Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build namespace to jenkins deployment #134

Merged
merged 1 commit into from
May 7, 2020
Merged

Add build namespace to jenkins deployment #134

merged 1 commit into from
May 7, 2020

Conversation

bparry02
Copy link
Contributor

@bparry02 bparry02 commented May 7, 2020

What does this PR do?

Specify the missing build namespace for Jenkins as described in #133.

How should this be tested?

$ oc new-project my-newproject
$ oc delete project my-newproject
$ ansible-playbook -i ./.applier/ galaxy/openshift-applier/playbooks/openshift-cluster-seed.yml

Is there a relevant Issue open for this?

fixes #133

Who would you like to review this?

cc: @redhat-cop/containers-approvers

@bparry02
Copy link
Contributor Author

bparry02 commented May 7, 2020

/assign @oybed

pabrahamsson
pabrahamsson approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@pabrahamsson pabrahamsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix @bparry02
/approve
/lgtm

@redhat-cop-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparry02, pabrahamsson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-cop-ci-bot redhat-cop-ci-bot merged commit ffa7b8c into redhat-cop:master May 7, 2020
@bparry02 bparry02 deleted the 133-jenkins-namespace branch June 29, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pabrahamsson pabrahamsson pabrahamsson approved these changes

Assignees

@pabrahamsson pabrahamsson

@oybed oybed

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

basic-spring-boot fails to deploy jenkins when context not set to build namespace
4 participants
@bparry02 @redhat-cop-ci-bot @pabrahamsson @oybed